Hi Zhijian, On Tue, Mar 19, 2024 at 11:43:50AM +0800, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() and scnprintf() will be converted as well if they have. This sentence seems to have been cut off halfway. If they have what? The code looks fine. Thanks, Wei.