On Fri, Mar 08, 2024 at 09:51:08AM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Applied to hyperv-next, thanks!
> ---
> drivers/hv/vmbus_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 7f7965f3d187..4cb17603a828 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -2359,10 +2359,9 @@ static int vmbus_platform_driver_probe(struct platform_device *pdev)
> return vmbus_acpi_add(pdev);
> }
>
> -static int vmbus_platform_driver_remove(struct platform_device *pdev)
> +static void vmbus_platform_driver_remove(struct platform_device *pdev)
> {
> vmbus_mmio_remove();
> - return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> @@ -2542,7 +2541,7 @@ static const struct dev_pm_ops vmbus_bus_pm = {
>
> static struct platform_driver vmbus_platform_driver = {
> .probe = vmbus_platform_driver_probe,
> - .remove = vmbus_platform_driver_remove,
> + .remove_new = vmbus_platform_driver_remove,
> .driver = {
> .name = "vmbus",
> .acpi_match_table = ACPI_PTR(vmbus_acpi_device_ids),
>
> base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
> --
> 2.43.0
>
