On Sun, Feb 18, 2024 at 12:03:06AM -0800, Saurabh Singh Sengar wrote: > On Sun, Feb 18, 2024 at 08:11:58AM +0100, Greg KH wrote: > > On Sat, Feb 17, 2024 at 10:03:35AM -0800, Saurabh Sengar wrote: > > > Add a function to query for the preferred ring buffer size of VMBus > > > device. > > > > That says what you did, but not why you did it. > > I thought subsequent patch will make it clear, but I can add more > info in cover letter. I will enhance this commit as well. Each patch should stand on its own, as it will be on its own when committed, right? I don't know anything is happening "next", nor what any of this means here, which is required. Again, what would _you_ want to see if you had to review this? Along those lines, why not get some internal review, and signed-off-by first, before asking us to review this for you? You all know this area the best, and have lots of experience with reviews, right? thanks, greg k-h
