On 09/11/2023 17:25, Dave Hansen wrote: > On 11/9/23 08:14, Jeremi Piotrowski wrote: > ... >> pr_info("Memory Encryption Features active:"); >> >> - if (cpu_feature_enabled(X86_FEATURE_TDX_GUEST)) { >> + if (cc_vendor == CC_VENDOR_INTEL) { >> pr_cont(" Intel TDX\n"); >> return; >> } > > Why aren't these guests setting X86_FEATURE_TDX_GUEST? They could if we can confirm that the code gated behind cpu_feature_enabled(X86_FEATURE_TDX_GUEST) is correct when running with TD partitioning. It still makes sense to have these prints based on the cc_xxx abstractions. Jeremi