On Wed, 2023-10-25 at 23:40 +0000, Justin Stitt wrote: > This patch converts some basic cases of ethtool_sprintf() to > ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > > ethtool_sprintf(&data, buffer[i].name); OK. > or when it's used with format string: "%s" > > ethtool_sprintf(&data, "%s", buffer[i].name); > > which both now become: > > ethtool_puts(&data, buffer[i].name); Why do you want this conversion? Is it not possible for .name to contain a formatting field?