> From: Dave Hansen <dave.hansen@xxxxxxxxx> > Sent: Friday, October 20, 2023 1:14 PM > To: Dexuan Cui <decui@xxxxxxxxxxxxx>; KY Srinivasan > [...] > On 10/20/23 13:00, Dexuan Cui wrote: > >> OK, then what good is this patch in the first place? If you are right, > >> then this would give equivalent information: > >> > >> cat /proc/cpuinfo | grep -q Intel && echo 'TDX' > >> cat /proc/cpuinfo | grep -q AMD && echo 'SEV' > >> > >> No kernel patching needed, right? > > Currently arch/x86/mm/mem_encrypt.c: > print_mem_encrypt_feature_info() > > prints an incorrect and confusing message > > "Memory Encryption Features active: AMD SEV". > > when an Intel TDX VM with a paravisor runs on Hyper-V. > > > > So I think a kernel patch is needed. > > How about either removing the message entirely or removing the ": AMD > SEV" part? It looks good to me if we can update/remove the message in print_mem_encrypt_feature_info(), but I guess AMD folks might want to keep the ": AMD SEV" part?