On 10/16/2023 4:49 AM, Alex Ionescu wrote:
Hi,
In arch/x86/include/asm/hyperv-tlfs.h, the following definition at
line 786 (in Linus' tree), I believe to be incorrect.
struct hv_enable_vp_vtl {
u64 partition_id;
u32 vp_index;
union hv_input_vtl target_vtl; <==== Here
For this hypercall, the TLFS and MSDN documentation states this field
is HV_VTL (u8) and not HV_INPUT_VTL (the bit-field used for targeting
hypercalls to specific target VTLs, which is not the case here).
I realize this is essentially a no-op in code at the moment, but for
correctness should be addressed? I'm happy to make a patch, but wanted
to make sure this isn't a mistake in TLFS/MSDN to begin with
(although, my copy of GDK headers would corroborate it's indeed HV_VTL
as well).
Best regards,
Alex Ionescu
Hi Alex,
I checked the code to make sure - seems like the TLFS doc is correct. It
should indeed be HV_VTL (u8).
Feel free to submit a patch.
Thanks
Nuno
