Re: [PATCH v4 07/15] Drivers: hv: Move hv_call_deposit_pages and hv_call_create_vp to common code

[kernel test robot <lkp@xxxxxxxxx>]

Hi Nuno,

kernel test robot noticed the following build errors:

[auto build test ERROR on arnd-asm-generic/master]
[also build test ERROR on arm64/for-next/core linus/master v6.6-rc4 next-20230929]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nuno-Das-Neves/hyperv-tlfs-Change-shared-HV_REGISTER_-defines-to-HV_MSR_/20230930-041305
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
patch link:    https://lore.kernel.org/r/1696010501-24584-8-git-send-email-nunodasneves%40linux.microsoft.com
patch subject: [PATCH v4 07/15] Drivers: hv: Move hv_call_deposit_pages and hv_call_create_vp to common code
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20231003/202310031047.K8WOyczC-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231003/202310031047.K8WOyczC-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310031047.K8WOyczC-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/hv/hv_common.c: In function 'hv_call_create_vp':
>> drivers/hv/hv_common.c:596:29: error: 'hv_current_partition_id' undeclared (first use in this function); did you mean 'hv_get_partition_id'?
     596 |         if (partition_id != hv_current_partition_id) {
         |                             ^~~~~~~~~~~~~~~~~~~~~~~
         |                             hv_get_partition_id
   drivers/hv/hv_common.c:596:29: note: each undeclared identifier is reported only once for each function it appears in


vim +596 drivers/hv/hv_common.c

   587	
   588	int hv_call_create_vp(int node, u64 partition_id, u32 vp_index, u32 flags)
   589	{
   590		struct hv_create_vp *input;
   591		u64 status;
   592		unsigned long irq_flags;
   593		int ret = HV_STATUS_SUCCESS;
   594	
   595		/* Root VPs don't seem to need pages deposited */
 > 596		if (partition_id != hv_current_partition_id) {
   597			/* The value 90 is empirically determined. It may change. */
   598			ret = hv_call_deposit_pages(node, partition_id, 90);
   599			if (ret)
   600				return ret;
   601		}
   602	
   603		do {
   604			local_irq_save(irq_flags);
   605	
   606			input = *this_cpu_ptr(hyperv_pcpu_input_arg);
   607	
   608			input->partition_id = partition_id;
   609			input->vp_index = vp_index;
   610			input->flags = flags;
   611			input->subnode_type = HvSubnodeAny;
   612			input->proximity_domain_info =
   613				numa_node_to_proximity_domain_info(node);
   614			status = hv_do_hypercall(HVCALL_CREATE_VP, input, NULL);
   615			local_irq_restore(irq_flags);
   616	
   617			if (hv_result(status) != HV_STATUS_INSUFFICIENT_MEMORY) {
   618				if (!hv_result_success(status)) {
   619					pr_err("%s: vcpu %u, lp %u, %s\n", __func__,
   620					       vp_index, flags, hv_status_to_string(status));
   621					ret = hv_status_to_errno(status);
   622				}
   623				break;
   624			}
   625			ret = hv_call_deposit_pages(node, partition_id, 1);
   626	
   627		} while (!ret);
   628	
   629		return ret;
   630	}
   631	EXPORT_SYMBOL_GPL(hv_call_create_vp);
   632	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki