On Mon, Sep 25, 2023 at 05:07:24PM -0700, Nuno Das Neves wrote: > On 9/23/2023 12:58 AM, Greg KH wrote: > > Also, drivers should never call pr_*() calls, always use the proper > > dev_*() calls instead. > > > > We only use struct device in one place in this driver, I think that is the > only place it makes sense to use dev_*() over pr_*() calls. Then the driver needs to be fixed to use struct device properly so that you do have access to it when you want to print messages. That's a valid reason to pass around your device structure when needed. thanks, greg k-h
