On Thu, Sep 07, 2023 at 09:52:34AM -0700, sharmaajay@xxxxxxxxxxxxxxxxx wrote: > From: Ajay Sharma <sharmaajay@xxxxxxxxxxxxx> > > Change from v4: > Send qp fatal error event to the context that > created the qp. Add lookup table for qp. > > Ajay Sharma (5): > RDMA/mana_ib : Rename all mana_ib_dev type variables to mib_dev > RDMA/mana_ib : Register Mana IB device with Management SW > RDMA/mana_ib : Create adapter and Add error eq > RDMA/mana_ib : Query adapter capabilities > RDMA/mana_ib : Send event to qp I didn't look very deep into the series and has three very initial comments. 1. Please do git log drivers/infiniband/hw/mana/ and use same format for commit messages. 2. Don't invent your own index-to-qp query mechanism in last patch and use xarray. 3. Once you decided to export mana_gd_register_device, it hinted me that it is time to move to auxbus infrastructure. Thanks > > drivers/infiniband/hw/mana/cq.c | 12 +- > drivers/infiniband/hw/mana/device.c | 81 +++-- > drivers/infiniband/hw/mana/main.c | 288 +++++++++++++----- > drivers/infiniband/hw/mana/mana_ib.h | 102 ++++++- > drivers/infiniband/hw/mana/mr.c | 42 ++- > drivers/infiniband/hw/mana/qp.c | 86 +++--- > drivers/infiniband/hw/mana/wq.c | 21 +- > .../net/ethernet/microsoft/mana/gdma_main.c | 152 +++++---- > drivers/net/ethernet/microsoft/mana/mana_en.c | 3 + > include/net/mana/gdma.h | 16 +- > 10 files changed, 545 insertions(+), 258 deletions(-) > > -- > 2.25.1 >
