Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue,  1 Aug 2023 17:32:44 -0700

> Handful of drivers currently expect to get xdp.h by virtue
> of including netdevice.h. This will soon no longer be the case
> so add explicit includes.
> 
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: j.vosburgh@xxxxxxxxx
> CC: andy@xxxxxxxxxxxxx
> CC: shayagr@xxxxxxxxxx
> CC: akiyano@xxxxxxxxxx
> CC: ioana.ciornei@xxxxxxx
> CC: claudiu.manoil@xxxxxxx
> CC: vladimir.oltean@xxxxxxx
> CC: wei.fang@xxxxxxx
> CC: shenwei.wang@xxxxxxx
> CC: xiaoning.wang@xxxxxxx
> CC: linux-imx@xxxxxxx
> CC: dmichail@xxxxxxxxxxxx
> CC: jeroendb@xxxxxxxxxx
> CC: pkaligineedi@xxxxxxxxxx
> CC: shailend@xxxxxxxxxx
> CC: jesse.brandeburg@xxxxxxxxx
> CC: anthony.l.nguyen@xxxxxxxxx
> CC: horatiu.vultur@xxxxxxxxxxxxx
> CC: UNGLinuxDriver@xxxxxxxxxxxxx
> CC: kys@xxxxxxxxxxxxx
> CC: haiyangz@xxxxxxxxxxxxx
> CC: wei.liu@xxxxxxxxxx
> CC: decui@xxxxxxxxxxxxx
> CC: peppe.cavallaro@xxxxxx
> CC: alexandre.torgue@xxxxxxxxxxx
> CC: joabreu@xxxxxxxxxxxx
> CC: mcoquelin.stm32@xxxxxxxxx
> CC: grygorii.strashko@xxxxxx
> CC: longli@xxxxxxxxxxxxx
> CC: sharmaajay@xxxxxxxxxxxxx
> CC: daniel@xxxxxxxxxxxxx
> CC: hawk@xxxxxxxxxx
> CC: john.fastabend@xxxxxxxxx
> CC: gerhard@xxxxxxxxxxxxxxxxxxxxx
> CC: simon.horman@xxxxxxxxxxxx
> CC: leon@xxxxxxxxxx
> CC: linux-hyperv@xxxxxxxxxxxxxxx
> CC: bpf@xxxxxxxxxxxxxxx
> ---
>  drivers/net/bonding/bond_main.c                       | 1 +
>  drivers/net/ethernet/amazon/ena/ena_netdev.h          | 1 +
>  drivers/net/ethernet/engleder/tsnep.h                 | 1 +
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h      | 1 +
>  drivers/net/ethernet/freescale/enetc/enetc.h          | 1 +
>  drivers/net/ethernet/freescale/fec.h                  | 1 +
>  drivers/net/ethernet/fungible/funeth/funeth_txrx.h    | 1 +
>  drivers/net/ethernet/google/gve/gve.h                 | 1 +
>  drivers/net/ethernet/intel/igc/igc.h                  | 1 +
>  drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 1 +
>  drivers/net/ethernet/microsoft/mana/mana_en.c         | 1 +
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h          | 1 +
>  drivers/net/ethernet/ti/cpsw_priv.h                   | 1 +
>  drivers/net/hyperv/hyperv_net.h                       | 1 +
>  drivers/net/tap.c                                     | 1 +
>  include/net/mana/mana.h                               | 2 ++
>  16 files changed, 17 insertions(+)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 7a0f25301f7e..2f21cca4fdaf 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -90,6 +90,7 @@
>  #include <net/tls.h>
>  #endif
>  #include <net/ip6_route.h>
> +#include <net/xdp.h>
>  
>  #include "bonding_priv.h"
>  
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> index 248b715b4d68..a1134152ecce 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
> @@ -15,6 +15,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/skbuff.h>
>  #include <uapi/linux/bpf.h>
> +#include <net/xdp.h>

Alphabetical sorting? :>
(for the entire patch)

>  
>  #include "ena_com.h"
>  #include "ena_eth_com.h"

[...]

Thanks,
Olek



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux