On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote: ... Hi Souradeep, > + for (i = 0; i < apc->num_queues; i++) { > + txq = &apc->tx_qp[i].txq; > + while (skb = skb_dequeue(&txq->pending_skbs)) { W=1 builds with both clang-16 and gcc-12 complain that they would like an extra set of parentheses around an assignment used as a truth value. > + mana_unmap_skb(skb, apc); > + dev_consume_skb_any(skb); > + } > + atomic_set(&txq->pending_sends, 0); > + } > /* We're 100% sure the queues can no longer be woken up, because > * we're sure now mana_poll_tx_cq() can't be running. > */ > -- > 2.34.1 > >