On 7/26/2023 10:29 PM, Michael Kelley (LINUX) wrote:
Hi Michael:
Thanks for your review. The patch mentioned by Boris has not been
merged and so still use X86_FEATURE_SEV_ES here. We may replace the
feature flag with X86_FEATURE_SEV_SNP after it's upstreamed.
Just so I'm clear, is it true that in an SEV-SNP VM, the CPUID flags for
SEV-ES*and* SEV-SNP are set? That would seem to be necessary for
your approach to work.
Yes, SEV and SEV-ES flags are set in the SEV-SNP guest and they are
necessary.
I wonder if it would be better to take the patch from Brijesh Singh
that adds X86_FEATURE_SEV_SNP and add it to your patch set (with
Brijesh's agreement, of course). That patch is small and straightforward.
I will sync with Brijesh. Thanks for suggestion.
