RE: [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: YueHaibing <yuehaibing@xxxxxxxxxx> Sent: Tuesday, July 25, 2023 6:59 AM
> 

I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
is much more commonly used and would give better overall consistency.

> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
> vmbus_ontimer()")
> this is not used anymore, so can remove it.

Indeed, yes!

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  include/linux/hyperv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index bfbc37ce223b..3ac3974b3c78 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
> *channel,
>  				     u32 *buffer_actual_len,
>  				     u64 *requestid);
> 
> -
> -extern void vmbus_ontimer(unsigned long data);
> -
>  /* Base driver object */
>  struct hv_driver {
>  	const char *name;
> --
> 2.34.1





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux