On Tue, Jun 06, 2023 at 11:52:06AM +0200, Simon Horman wrote: > + Praveen Kumar > > On Mon, Jun 05, 2023 at 04:30:06AM -0700, Shradha Gupta wrote: > > Allocate the size of rx indirection table dynamically in netvsc > > from the value of size provided by OID_GEN_RECEIVE_SCALE_CAPABILITIES > > query instead of using a constant value of ITAB_NUM. > > > > Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > Tested-on: Ubuntu22 (azure VM, SKU size: Standard_F72s_v2) > > Testcases: > > 1. ethtool -x eth0 output > > 2. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-Synthetic > > 3. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-SRIOV > > Hi Praveen, all, > > it seems that there has not been any non-trivial review of this > patchset since v3. But at that point there was some feedback > from you. So I'd like to ask if you have any feedback on v6 [1]. > > [1] https://lore.kernel.org/all/1685964606-24690-1-git-send-email-shradhagupta@xxxxxxxxxxxxxxxxxxx/ > For the record: I see that Praveen has now provided a Reviewed-by for v3 [2], thanks! I think this patch is clear now. Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx> [2] https://lore.kernel.org/all/bb461c30-3eb0-74c0-d637-c4a3bdf84565@xxxxxxxxxxxxxxxxxxx/