> -----Original Message----- > From: Wei Liu <wei.liu@xxxxxxxxxx> > Sent: Friday, June 2, 2023 9:53 PM > To: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx> > Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; wei.liu@xxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; > bp@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; Michael Kelley > (LINUX) <mikelley@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux- > hyperv@xxxxxxxxxxxxxxx; hpa@xxxxxxxxx > Subject: [EXTERNAL] Re: [PATCH] x86/hyperv: add noop functions to x86_init > mpparse functions > > On Fri, Jun 02, 2023 at 05:41:52AM -0700, Saurabh Sengar wrote: > > In !ACPI system, there is no way to disable CONFIG_X86_MPPARSE. > > When CONFIG_X86_MPPARSE is enabled for VTL2, the kernel will scan low > > memory looking for MP tables. Don't allow this, because low memory is > > controlled by VTL0 and may contain actual valid tables for VTL0, which > > can confuse the VTL2 kernel. > > > > Signed-off-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx> > > --- > > arch/x86/hyperv/hv_vtl.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/x86/hyperv/hv_vtl.c b/arch/x86/hyperv/hv_vtl.c index > > 1ba5d3b99b16..ea21d897b5da 100644 > > --- a/arch/x86/hyperv/hv_vtl.c > > +++ b/arch/x86/hyperv/hv_vtl.c > > @@ -23,6 +23,10 @@ void __init hv_vtl_init_platform(void) > > x86_init.irqs.pre_vector_init = x86_init_noop; > > x86_init.timers.timer_init = x86_init_noop; > > > > + /* Avoid searching for BIOS MP tables */ > > + x86_init.mpparse.find_smp_config = x86_init_noop; > > + x86_init.mpparse.get_smp_config = x86_init_uint_noop; > > + > > The code looks fine. > > Can you expand the commit message a bit so that people who are not > familiar with VTL and your setup can understand what's going on? Sure, I will add more details in commit message. > > Thanks, > Wei. > > > x86_platform.get_wallclock = get_rtc_noop; > > x86_platform.set_wallclock = set_rtc_noop; > > x86_platform.get_nmi_reason = hv_get_nmi_reason; > > -- > > 2.34.1 > >
