On Tue, May 30, 2023 at 08:14:53PM -0700, Shradha Gupta wrote:
> Allocate the size of rx indirection table dynamically in netvsc
> from the value of size provided by OID_GEN_RECEIVE_SCALE_CAPABILITIES
> query instead of using a constant value of ITAB_NUM.
>
> Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Tested-on: Ubuntu22 (azure VM, SKU size: Standard_F72s_v2)
> Testcases:
> 1. ethtool -x eth0 output
> 2. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-Synthetic
...
> @@ -1596,11 +1609,17 @@ void rndis_filter_device_remove(struct hv_device *dev,
> struct netvsc_device *net_dev)
> {
> struct rndis_device *rndis_dev = net_dev->extension;
> + struct net_device *net = hv_get_drvdata(dev);
> + struct net_device_context *ndc = netdev_priv(net);
nit: I know this file doesn't follow the scheme very closely,
but I'd preferred if it moved towards it.
Please use reverse xmas tree - longest line to shortest -
for local variable declarations in networking code.
struct rndis_device *rndis_dev = net_dev->extension;
struct net_device *net = hv_get_drvdata(dev);
struct net_device_context *ndc;
ndc = netdev_priv(net);
>
> /* Halt and release the rndis device */
> rndis_filter_halt_device(net_dev, rndis_dev);
>
> netvsc_device_remove(dev);
> +
> + ndc->rx_table_sz = 0;
> + kfree(ndc->rx_table);
> + ndc->rx_table = NULL;
> }
--
pw-bot: cr
