> -----Original Message----- > From: Dave Hansen <dave.hansen@xxxxxxxxx> > Sent: Tuesday, May 23, 2023 11:23 PM > To: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>; tglx@xxxxxxxxxxxxx; > mingo@xxxxxxxxxx; bp@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; > x86@xxxxxxxxxx; hpa@xxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; > Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; wei.liu@xxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; Michael Kelley (LINUX) <mikelley@xxxxxxxxxxxxx>; > linux-kernel@xxxxxxxxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx > Cc: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx> > Subject: [EXTERNAL] Re: [PATCH 1/2] x86/Kconfig: Allow > CONFIG_X86_MPPARSE disable for OF platforms > > On 5/11/23 07:54, Saurabh Sengar wrote: > > X86_MPPARSE is only selectable when ACPI is enabled. However, on > > Devicetree platforms where ACPI is disabled, it is always enabled. > > Allow X86_MPPARSE to be selected by OF platforms as well. > > I'm finding this changelog really hard to read. > > In Kconfig, you can "select FOO". But in this changelog, it means something > different. I think "selectable" here means that there's a user prompt for the > option. > > Could you please rephrase this to be less confusing? Thanks for your review. Currently, in the absence of ACPI, it is impossible to disable X86_MPPARSE. In the case of ACPI being enabled, one has the option to either enable or disable X86_MPARSE. My intention is to permit X86_MPPARSE=n for OF platforms where ACPI=n. To describe the capability of choosing any desired value for MPPARSE, I used the term 'selectable.' Perhaps 'configurable' would be a more appropriate word in this context? I can fix this and include it in V2. > > This is also one of those patches where I wonder: Why do _you_ care about > this? Are you just trying to be nice? Is this intended as some kind of cleanup? It solves an issue for Hyper-V VBS setup, please refer to the 2/2 of this patch series. Regards, Saurabh
