Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> :
[...]
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index 492474b4d8aa..07738b7e85f2 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -427,6 +427,34 @@ static u16 mana_select_queue(struct net_device *ndev, struct sk_buff *skb,
> return txq;
> }
>
> +static int mana_change_mtu(struct net_device *ndev, int new_mtu)
> +{
> + unsigned int old_mtu = ndev->mtu;
> + int err, err2;
> +
> + err = mana_detach(ndev, false);
> + if (err) {
> + netdev_err(ndev, "mana_detach failed: %d\n", err);
> + return err;
> + }
> +
> + ndev->mtu = new_mtu;
> +
> + err = mana_attach(ndev);
> + if (!err)
> + return 0;
> +
> + netdev_err(ndev, "mana_attach failed: %d\n", err);
> +
> + /* Try to roll it back to the old configuration. */
> + ndev->mtu = old_mtu;
> + err2 = mana_attach(ndev);
> + if (err2)
> + netdev_err(ndev, "mana re-attach failed: %d\n", err2);
> +
> + return err;
> +}
I do not see where the driver could depend on the MTU. Even if it fails,
a single call to mana_change_mtu should thus never wreck the old working
state/configuration.
Stated differently, the detach/attach implementation is simple but
it makes the driver less reliable than it could be.
No ?
--
Ueimor
