On 10/03/2023 18:17, Michael Kelley (LINUX) wrote: > From: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> >> >> Annotate the function prototype as noreturn to prevent objtool >> warnings like: > > Just curious: Should the actual function also be updated with > __noreturn? In similar situations, such as snp_abort(), the > __noreturn attribute is both places. I don't know what the > guidance is on this question. > > In any case, thanks for doing this cleanup! > > Michael Thanks Michael! In my understanding (anybody please correct me if I'm wrong) any user of this function that rely on this header will "inherit" the attribute - hence, if this function is not used in any other header or statically inside it's own definition file, it's not necessary. But I'm glad in submitting a V3 with that if it's better, let me know. Cheers, Guilherme
