On 08/02/2023 15:39, Nathan Chancellor wrote: > On Wed, Feb 08, 2023 at 11:25:57AM +0100, Krzysztof Kozlowski wrote: >> On 08/02/2023 09:22, kernel test robot wrote: >>> Hi Saurabh, >>> >>> Thank you for the patch! Perhaps something to improve: >>> >>> [auto build test WARNING on next-20230207] >>> [cannot apply to robh/for-next tip/timers/core brgl/gpio/for-next wsa/i2c/for-next linus/master v6.2-rc7 v6.2-rc6 v6.2-rc5 v6.2-rc7] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch#_base_tree_information] >>> >> >> All of your recent patches have build errors. Can you at least build >> test them before sending? It's a unnecessary noise in our mailboxes to >> get non-buildable patches, just to trigger compilation which you can >> easily do by your own. GCC is a free software... > > For what it's worth, GCC does not have a warning like this, it just > accepts the incorrect location of the attribute, which has gotten others > in trouble before: > > https://lore.kernel.org/CAHk-=wgf+kHeSZbpkZumWcTXUD7ordqTMvPRNL6aQVG1DSBDnQ@xxxxxxxxxxxxxx/ > > So the patch probably did build clean with GCC but that is one of the > reasons that there is no longer a compiler monopoly for the kernel ;) OK then the patchset is reasonable/built enough. Best regards, Krzysztof
