On 18/09/2022 11:10, Guilherme G. Piccoli wrote: > On 19/08/2022 19:17, Guilherme G. Piccoli wrote: >> The altera_edac panic notifier performs some data collection with >> regards errors detected; such code relies in the regmap layer to >> perform reads/writes, so the code is abstracted and there is some >> risk level to execute that, since the panic path runs in atomic >> context, with interrupts/preemption and secondary CPUs disabled. >> >> Users want the information collected in this panic notifier though, >> so in order to balance the risk/benefit, let's skip the altera panic >> notifier if kdump is loaded. While at it, remove a useless header >> and encompass a macro inside the sole ifdef block it is used. >> >> Cc: Borislav Petkov <bp@xxxxxxxxx> >> Cc: Petr Mladek <pmladek@xxxxxxxx> >> Cc: Tony Luck <tony.luck@xxxxxxxxx> >> Acked-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> >> Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> >> >> --- >> >> V3: >> - added the ack tag from Dinh - thanks! >> - had a good discussion with Boris about that in V2 [0], >> hopefully we can continue and reach a consensus in this V3. >> [0] https://lore.kernel.org/lkml/46137c67-25b4-6657-33b7-cffdc7afc0d7@xxxxxxxxxx/ >> >> V2: >> - new patch, based on the discussion in [1]. >> [1] https://lore.kernel.org/lkml/62a63fc2-346f-f375-043a-fa21385279df@xxxxxxxxxx/ >> >> [...] > > Hi Dinh, Tony, Boris - sorry for the ping. Hey folks, apologies for the new ping. Is there anything to improve here maybe? Reviews / opinions are very appreciated! Cheers, Guilherme
