On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Currently the tracing dump_on_oops feature is implemented through > separate notifiers, one for die/oops and the other for panic; > given they have the same functionality, let's unify them. > > Also improve the function comment and change the priority of the > notifier to make it execute earlier, avoiding showing useless trace > data (like the callback names for the other notifiers); finally, > we also removed an unnecessary header inclusion. > > Cc: Petr Mladek <pmladek@xxxxxxxx> > Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> > > --- > > V3: > - Removed goto usage, as per Steven suggestion (thanks!). > > V2: > - Different approach; instead of using IDs to distinguish die and > panic events, rely on address comparison like other notifiers do > and as per Petr's suggestion; > > - Removed ACK from Steven since the code changed. > > [...] Hi Steve, Alan - sorry for the ping (and I'm aware you're OOO Steve, saw your auto-response email heh). So, is this version good enough? Appreciate the reviews and in case it's good, let me know your preference for picking it in your tree - I could resend the patch alone if you prefer (not in the series), for example. Thanks, Guilherme
