Hi Bobby, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master v6.0-rc1 next-20220815] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bobby-Eshleman/virtio-vsock-introduce-dgrams-sk_buff-and-qdisc/20220816-015812 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220816/202208160300.HYFUSTbF-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/68c9c8216a573cdfe2170cad677854e2f4a34634 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bobby-Eshleman/virtio-vsock-introduce-dgrams-sk_buff-and-qdisc/20220816-015812 git checkout 68c9c8216a573cdfe2170cad677854e2f4a34634 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/vmw_vsock/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> net/vmw_vsock/virtio_transport.c:178: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Merge the two most recent skbs together if possible. vim +178 net/vmw_vsock/virtio_transport.c 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 176 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 177 /** 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 @178 * Merge the two most recent skbs together if possible. 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 179 * 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 180 * Caller must hold the queue lock. 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 181 */ 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 182 static void 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 183 virtio_transport_add_to_queue(struct sk_buff_head *queue, struct sk_buff *new) 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 184 { 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 185 struct sk_buff *old; 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 186 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 187 spin_lock_bh(&queue->lock); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 188 /* In order to reduce skb memory overhead, we merge new packets with 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 189 * older packets if they pass virtio_transport_skbs_can_merge(). 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 190 */ 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 191 if (skb_queue_empty_lockless(queue)) { 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 192 __skb_queue_tail(queue, new); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 193 goto out; 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 194 } 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 195 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 196 old = skb_peek_tail(queue); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 197 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 198 if (!virtio_transport_skbs_can_merge(old, new)) { 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 199 __skb_queue_tail(queue, new); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 200 goto out; 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 201 } 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 202 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 203 memcpy(skb_put(old, new->len), new->data, new->len); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 204 vsock_hdr(old)->len = cpu_to_le32(old->len); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 205 vsock_hdr(old)->buf_alloc = vsock_hdr(new)->buf_alloc; 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 206 vsock_hdr(old)->fwd_cnt = vsock_hdr(new)->fwd_cnt; 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 207 dev_kfree_skb_any(new); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 208 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 209 out: 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 210 spin_unlock_bh(&queue->lock); 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 211 } 93afaf2cdefaa9 Bobby Eshleman 2022-08-15 212 -- 0-DAY CI Kernel Test Service https://01.org/lkp
