On Sun, 2022-08-07 at 12:40 -0300, Guilherme G. Piccoli wrote: > On 19/07/2022 16:53, Guilherme G. Piccoli wrote: > > Currently the panic notifiers from user mode linux don't follow > > the convention for most of the other notifiers present in the > > kernel (indentation, priority setting, numeric return). > > More important, the priorities could be improved, since it's a > > special case (userspace), hence we could run the notifiers earlier; > > user mode linux shouldn't care much with other panic notifiers but > > the ordering among the mconsole and arch notifier is important, > > given that the arch one effectively triggers a core dump. > > > > Fix that by running the mconsole notifier as the first panic > > notifier, followed by the architecture one (that coredumps). > > > > Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx> > > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > Cc: Richard Weinberger <richard@xxxxxx> > > Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> > > > > --- > > > > V2: > > - Kept the notifier header to avoid implicit usage - thanks > > Johannes for the suggestion! > > > > arch/um/drivers/mconsole_kern.c | 7 +++---- > > arch/um/kernel/um_arch.c | 8 ++++---- > > 2 files changed, 7 insertions(+), 8 deletions(-) > > [...] > > Hi Johannes, do you feel this one is good now, after your last review? > Thanks in advance, > Yeah, no objections, my previous comment was just a minor almost style issue anyway. johannes
