On 19/07/2022 16:53, Guilherme G. Piccoli wrote: > Currently the tracing dump_on_oops feature is implemented > through separate notifiers, one for die/oops and the other > for panic - given they have the same functionality, let's > unify them. > > Also improve the function comment and change the priority of > the notifier to make it execute earlier, avoiding showing useless > trace data (like the callback names for the other notifiers); > finally, we also removed an unnecessary header inclusion. > > Cc: Petr Mladek <pmladek@xxxxxxxx> > Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx> > > --- > > V2: > - Different approach; instead of using IDs to distinguish die and > panic events, rely on address comparison like other notifiers do > and as per Petr's suggestion; > > - Removed ACK from Steven since the code changed. > > kernel/trace/trace.c | 55 ++++++++++++++++++++++---------------------- > 1 file changed, 27 insertions(+), 28 deletions(-) > [...] Hi Sergei / Steve, do you think this version is good now, after your last round of reviews? Thanks, Guilherme
