On Thu, Jul 07, 2022, Vitaly Kuznetsov wrote: > Jim Mattson <jmattson@xxxxxxxxxx> writes: > > > On Wed, Jun 29, 2022 at 8:07 AM Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote: > >> > >> From: Sean Christopherson <seanjc@xxxxxxxxxx> > >> > >> Clear the CR3 and INVLPG interception controls at runtime based on > >> whether or not EPT is being _used_, as opposed to clearing the bits at > >> setup if EPT is _supported_ in hardware, and then restoring them when EPT > >> is not used. Not mucking with the base config will allow using the base > >> config as the starting point for emulating the VMX capability MSRs. > >> > >> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> > >> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> > > Nit: These controls aren't "obsoleted" by EPT; they're just no longer > > required. Isn't that the definition of "obsolete"? They're "no longer in use" when KVM enables EPT. > I'm going to update the subject line to "KVM: VMX: Clear controls > unneded with EPT at runtime, not setup" retaining your authorship in v3 That's fine, though s/unneded/unneeded.
