On 25.02.22 16:43, Jason A. Donenfeld wrote:
Hi Alex,
On Fri, Feb 25, 2022 at 04:22:54PM +0100, Alexander Graf wrote:
I don't understand the rush here. This had been sitting on the ML for 1
year - and now suddenly talking the match through properly and getting
VMGenID spec compatible matching support into the ACPI core is a
problem? What did I miss? :)
I don't think this is a question about speed. Ard doesn't like the spec.
You like the feature more than you dislike the spec. Apparently that
means there's a disagreement.
As I mentioned earlier, I'd encourage you to send a patch to the ACPI
people and let them decide. If that gets in, then I'm fine with
modifying vmgenid to meet the spec and take advantage of the change
you'll be making to the ACPI code. If it is rejected by the ACPI people,
and consequently Linux isn't able to match on _CID, then I guess we'll
have the next best thing, which is "well, it still works on QEMU."
Hopefully you'll convince them. Feel free to CC me on that patch.
I agree with that approach and CC'ed you on the ACPI patch :). Let's
explore all options to match against _CID before we give up.
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879