On Fri, Feb 04, 2022 at 06:34:17PM -0800, Iouri Tarassov wrote: The subject line does not make sense, it is not a sentence. > These IOCTLs are logically simple: What is "these"? > - input data is read > - a message is sent to the host > - the result is returned to the caller > > - LX_DXESCAPE (D3DKMTEscape) > This IOCTL is used to send/receive private data between user mode > driver and kernel mode driver. This is an extension of the WDDM APIs. > > - LX_DXMARKDEVICEASERROR (D3DKMTMarkDeviceAsError) > The IOCTL is used to bring the dxgdevice object to the error state. > Subsequent calls to use the device object will fail. > > - LX_DXQUERYSTATISTICS (D3DKMTQuerystatistics) > The IOCTL is used to query various statistics from the compute device > on the host. > > - LX_DXQUERYCLOCKCALIBRATION > The IOCTL queries clock from the compute device. Why is this not broken up into one-patch-per-ioctl like I asked? {sigh} I'm not reviewing this anymore, please rework it. thanks, greg k-h