On 31 Jan 15:19, Florian Fainelli wrote:
On 1/31/2022 3:13 PM, Jakub Kicinski wrote:
On Mon, 31 Jan 2022 15:06:01 -0800 Florian Fainelli wrote:
Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a
NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set
to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your
old defconfig breaks.
To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which
are in tree and can be updated.
The oldconfigs would have to not be updated on any intervening kernel
in the last 10+ years to break, right? Or is there another way that an
oldconfig would not have the vendor config set to y at this point?
That sounds very unrealistic, so yes, I don't think at this point that
would happen. Even if you had your 15 year old .config file and ran
make oldconfig today, you would have some work to do to make sure it
still runs on your hardware.
I am getting mixed messages here, on one hand we know that this patch
might break some old or def configs, but on the other hand people claim
that they have to manually fixup their own configs every time
"something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for
the greater good" .. that's my .2cent.
Thanks,
Saeed.
