On Tue, Dec 07, 2021 at 02:55:58AM -0500, Tianyu Lan wrote:
> From: Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>
>
> Hyper-V provides Isolation VM which has memory encrypt support. Add
> hyperv_cc_platform_has() and return true for check of GUEST_MEM_ENCRYPT
> attribute.
You need to refresh on how to write commit messages - never say what the
patch is doing - that's visible in the diff itself. Rather, you should
talk about *why* it is doing what it is doing.
> bool cc_platform_has(enum cc_attr attr)
> {
> + if (hv_is_isolation_supported())
> + return hyperv_cc_platform_has(attr);
Is there any reason for the hv_is_.. check to come before...
> +
> if (sme_me_mask)
> return amd_cc_platform_has(attr);
... the sme_me_mask check?
What's in sme_me_mask on hyperv?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
