Can you put some specifics in the subject line, please? If this patch does several things, that might be an indication that it should be split into several patches. On Fri, Oct 08, 2021 at 05:20:35PM +0000, Sunil Muthuswamy wrote: > This patch makes the Hyper-V vPCI code architectural neutral by > introducing an irqchip that takes care of architectural > dependencies. This allows for the implementation of Hyper-V vPCI > for other architecture such as ARM64. No need to include "This patch"; we already know we're talking about this patch. Write in "imperative mood", e.g., "Encapsulate arch dependencies in X ..." instead of "This patch makes the code ...". See https://chris.beams.io/posts/git-commit/ Wrap the text to fill 75 columns. You said this "introduces an irqchip", but I don't see a new struct irq_chip or similar. The important part about making this arch-neutral seems to be adding these interfaces that will encapsulate arch dependencies: hv_pci_irqchip_init() hv_pci_irqchip_free() hv_msi_get_int_vector() hv_set_msi_entry_from_desc() hv_msi_prepare() I'm not sure wrapping them in "#ifdef CONFIG_X86_64" is the best approach, but the IRQ folks will know better. > +++ b/drivers/pci/controller/pci-hyperv-irqchip.c > @@ -0,0 +1,51 @@ > +// SPDX-License-Identifier: GPL-2.0 > + Spurious blank line (follow style of nearby files). > +/* > + * Hyper-V vPCI irqchip. > +++ b/drivers/pci/controller/pci-hyperv-irqchip.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + Spurious blank line (follow style of nearby files). > +/* > + * Architecture specific vector management for the Hyper-V vPCI.
