On Thu, Jul 22, 2021 at 10:25:46AM -0700, Linus Torvalds wrote: > On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <wei.liu@xxxxxxxxxx> wrote: > > > > - Reversion of a bogus patch that went into 5.14-rc1 > > When doing a revert, please explain it. > > Yes, they are simple in the sense that they just undo something, but > at the same time, that "something" was done for a reason, and the > reason why that original change was wrong, and how it was noticed (ie > what the symptoms of the reverted patch were) is important. > > I've pulled this, so it's too late now, but please please please > explain reverts in the future, not just a "This reverts commit XYZ". > Sure. Noted. Thanks, Wei.