On Wed, 2021-05-26 at 21:42 +0200, Thomas Zimmermann wrote: > Hi > > Am 20.05.21 um 07:41 schrieb Dexuan Cui: > > > From: Deepak Rawat <drawat.floss@xxxxxxxxx> > > > Sent: Wednesday, May 19, 2021 9:38 AM > > > ... > > > +static int hyperv_vmbus_suspend(struct hv_device *hdev) > > > +{ > > > + struct drm_device *dev = hv_get_drvdata(hdev); > > > + int ret; > > > + > > > + ret = drm_mode_config_helper_suspend(dev); > > > > If 'ret' is not zero, return immediately? > > > > > + > > > + vmbus_close(hdev->channel); > > > + > > > + return ret; > > > +} > > > > > > > +MODULE_DESCRIPTION("DRM driver for hyperv synthetic video > > > device"); > > > > s/hyperv/Hyper-V ? > > > > Maybe let's fix these points and then get the driver merged. Hi Thomas, sure. This was on my list to fix before merge. One patch is missing ack/review, so it would be nice if that also is reviewed. Thanks, Deepak > > Best regards > Thomas >