> From: Arnd Bergmann <arnd@xxxxxxxxxx> > Sent: Thursday, April 22, 2021 6:35 AM > ... > From: Arnd Bergmann <arnd@xxxxxxxx> > > The MANA driver causes a build failure in some configurations when > it selects an unavailable symbol: > > WARNING: unmet direct dependencies detected for PCI_HYPERV > Depends on [n]: PCI [=y] && X86_64 [=y] && HYPERV [=n] && PCI_MSI [=y] > && PCI_MSI_IRQ_DOMAIN [=y] && SYSFS [=y] > Selected by [y]: > - MICROSOFT_MANA [=y] && NETDEVICES [=y] && ETHERNET [=y] && > NET_VENDOR_MICROSOFT [=y] && PCI_MSI [=y] && X86_64 [=y] > drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask': > drivers/pci/controller/pci-hyperv.c:1217:9: error: implicit declaration of > function 'hv_set_msi_entry_from_desc' > [-Werror=implicit-function-declaration] > 1217 | > hv_set_msi_entry_from_desc(¶ms->int_entry.msi_entry, msi_desc); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > A PCI driver should never depend on a particular host bridge > implementation in the first place, but if we have this dependency > it's better to express it as a 'depends on' rather than 'select'. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
