Re: [PATCH v2 5/7] KVM: SVM: hyper-v: Remote TLB flush for SVM

[Vineeth Pillai <viremana@xxxxxxxxxxxxxxxxxxx>]

On 4/16/2021 1:26 PM, Vineeth Pillai wrote:
> >   +#if IS_ENABLED(CONFIG_HYPERV)
> > +static void hv_init_vmcb(struct vmcb *vmcb)
> > +{
> > +    struct hv_enlightenments *hve = &vmcb->hv_enlightenments;
> > +
> > +    if (npt_enabled &&
> > +        ms_hyperv.nested_features & HV_X64_NESTED_ENLIGHTENED_TLB)
> > Nitpick: we can probably have a 'static inline' for
> >
> >   "npt_enabled && ms_hyperv.nested_features & 
> > HV_X64_NESTED_ENLIGHTENED_TLB"
> >
> > e.g. 'hv_svm_enlightened_tlbflush()'
> Makes sense, will do.
On a second thought, this function itself is small and just does this 
one check.
So, might not make sense to add one more function. I shall rather change 
this
function to be an inline.

Thanks,
Vineeth