On Wed, Apr 07, 2021 at 09:59:52PM +0000, Dexuan Cui wrote: > > From: Leon Romanovsky <leon@xxxxxxxxxx> > > Sent: Wednesday, April 7, 2021 5:45 AM > > > > > > > > BTW, you don't need to write { 0 }, the {} is enough. > > > > > > Thanks for the suggestion! I'll use {0} in v2. > > > > You missed the point, "{ 0 }" change to be "{}" without 0. > > Got it. Will make the suggested change. The numbers are not important, if you are curious, read this thread, it talks about {}, {0}, memset(0,..) and padding :) https://lore.kernel.org/linux-rdma/20200730192026.110246-1-yepeilin.cs@xxxxxxxxx/ > > FWIW, {0} and { 0 } are still widely used, but it looks like > {} is indeed more preferred: > > $ grep "= {};" drivers/net/ -nr | wc -l > 829 > > $ grep "= {0};" drivers/net/ -nr | wc -l > 708 > > $ grep "= {};" kernel/ -nr | wc -l > 29 > > $ grep "= {0};" kernel/ -nr | wc -l > 4