Wei Liu <wei.liu@xxxxxxxxxx> writes: > On Wed, Apr 07, 2021 at 09:38:21AM +0200, Vitaly Kuznetsov wrote: > >> One more though: it is probably a good idea to introduce selftests for >> /dev/mshv (similar to KVM's selftests in >> /tools/testing/selftests/kvm). Selftests don't really need a stable ABI >> as they live in the same linux.git and can be updated in the same patch >> series which changes /dev/mshv behavior. Selftests are very useful for >> checking there are no regressions, especially in the situation when >> there's no publicly available userspace for /dev/mshv. > > I think this can wait until we merge the first implementation in tree. > There are still a lot of moving parts. Our (currently limited) internal > test cases need more cleaning up before they are ready. I certainly > don't want to distract Nuno from getting the foundation right. > I'm absolutely fine with this approach, selftests are a nice add-on, not a requirement for the initial implementation. Also, to make them more useful to mere mortals, a doc on how to run Linux as root Hyper-V partition would come handy) -- Vitaly
