Hi Lorenzo, On Mon, 22 Mar 2021 12:23:15 +0000, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> wrote: > > On Thu, Feb 25, 2021 at 03:10:13PM +0000, Marc Zyngier wrote: > > In anticipation of the removal of the msi_controller structure, convert > > the ancient xilinx host controller driver to MSI domains. > > > > We end-up with the usual two domain structure, the top one being a > > generic PCI/MSI domain, the bottom one being xilinx-specific and handling > > the actual HW interrupt allocation. > > > > This allows us to fix some of the most appaling MSI programming, where > > the message programmed in the device is the virtual IRQ number instead > > of the allocated vector number. The allocator is also made safe with > > a mutex. This should allow support for MultiMSI, but I decided not to > > even try, since I cannot test it. > > > > Also take the opportunity to get rid of the cargo-culted memory allocation > > for the MSI capture address. *ANY* sufficiently aligned address should > > be good enough, so use the physical address of the xilinx_pcie_host > > structure instead. > > I'd agree with Bjorn that the MSI doorbell change is better split into > a separate patch, I can do it myself at merge if you agree. I need to respin the series as it now conflicts badly with the current state of the tree (rcar has introduced one subtle change that needs addressing). I'll post that later this week (hopefully tomorrow) with rcar and xilinx having the doorbell fix in separate patches. Thanks, M. -- Without deviation from the norm, progress is not possible.
