From: Melanie Plageman (Microsoft) <melanieplageman@xxxxxxxxx> > This patch contains a section which seems to be a copy&paste error > from another email. I don't think that there are any unintentional portions to the email. Andres gave me feedback on my patch. I addressed his feedback in an updated version of the patch but wanted to include additional context and points which did not belong in the commit message. After some research online, I was led to believe that doing so below the commit message was an appropriate way to add relevant context to the patch which may not belong in the commit message (using --annotate or --compose with git-send-email). The patch still applied cleanly for me. My intent was the following: I received feedback on the code in the patch and wanted to address that feedback with an updated version of the patch. I also wanted to respond inline to the specific comments with text to continue the discussion. Additionally, I wanted to make sure that the new patch showed a clear diff with the old patch so that it was clear what I changed in response to feedback. If I had started a new thread with this new version, I feared a two-patch set would no longer make sense, as the two commits should be fixed up together in a final version. What would have been the appropriate way to achieve this that aligns more closely with the convention of the list? > Also, please use get_maintainers.pl to CC the correct maintainers. You > can configure git-sendemail such that the correct people are CC'ed > automatically. The storvsc code normally goes via the storage > maintainers' tree. > > If you have any question about how to use the get_maintainers.pl script > or the upstreaming process in general, let me know. I created this CC list after running get_maintainers.pl on my patch (and then used git-send-email to send it). It returned these people and lists: K. Y. Srinivasan [kys@xxxxxxxxxxxxx] Haiyang Zhang [haiyangz@xxxxxxxxxxxxx] Stephen Hemminger [sthemmin@xxxxxxxxxxxxx] Sasha Levin [sashal@xxxxxxxxxx] James E.J. Bottomley [jejb@xxxxxxxxxxxxx] Martin K. Petersen [martin.petersen@xxxxxxxxxx] [linux-hyperv@xxxxxxxxxxxxxxx] [linux-scsi@xxxxxxxxxxxxxxx] [linux-kernel@xxxxxxxxxxxxxxx] I chose to CC the four people listed as suporters for Hyper-V core and drivers and exclude SCSI maintainers, as this patch doesn't seem to have much impact outside of storvsc. Same rationale for excluding the SCSI list and main linux kernel list. Regards, Melanie
