On Tue, Jan 05, 2021 at 11:04:15PM +0000, Dexuan Cui wrote: > > From: Wei Liu <wei.liu@xxxxxxxxxx> > > Sent: Tuesday, January 5, 2021 4:58 AM > > > ... > > > Documentation/ABI/stable/sysfs-bus-vmbus | 7 +++++++ > > > drivers/hv/vmbus_drv.c | 20 > > ++++++++++++++++++++ > > > 2 files changed, 27 insertions(+) > > > > > > diff --git a/Documentation/ABI/stable/sysfs-bus-vmbus > > b/Documentation/ABI/stable/sysfs-bus-vmbus > > > index c27b7b89477c..3ba765ae6695 100644 > > > --- a/Documentation/ABI/stable/sysfs-bus-vmbus > > > +++ b/Documentation/ABI/stable/sysfs-bus-vmbus > > > @@ -1,3 +1,10 @@ > > > +What: /sys/bus/vmbus/supported_features > > > +Date: Dec 2020 > > > +KernelVersion: 5.11 > > > > Too late for 5.11 now. > > The patch was posted 2 weeks ago, before 5.11-rc1. :-) > > If possible, we still want this patch to be in 5.11, because: > 1. The patch is small and IMO pretty safe. > 2. The patch adds new code and doesn't really change any old code. > 3. The patch adds a new sys file, which is needed by some > user space tool to auto-setup the configuration for hibernation. > We'd like to integrate the patch into the Linux distros ASAP and > as we know some distros don't accept a patch if it's not in the > mainline. > > So, if the patch itself looks good, IMO it would be better to be > in v5.11 rather than in v5.12, which will need extra time of > 2~3 months. > > That said, I don't know if there is any hard rule in regard of > the timing here. If there is, then v5.12 is OK to me. :-) > By the time you posted this (Dec 22), 5.11 was already more or less "frozen". Linus wanted -next patches to be merged before Christmas. The way I see it this is a new sysfs interface so I think this is something new, which is for 5.12. Do you think this should be considered a bug fix? Wei. > > Given this is a list of strings, do you want to enumerate them in a > > Values section or the Description section? > > > > Wei. > > Currently there is only one possible string "hibernation". > Not sure if we would need to add more strings in future, but yes > it's a good idea to list the string in a "Value" section. > > Will post v2 shortly. > > Thanks, > -- Dexuan
