Em 11/24/2020 11:56 PM, Joe Perches escreveu:
On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote:
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
The above would be marginally better if organized as follows so that the
main execution path isn't in an "if" clause. Also reduces indentation.
hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
if (!hv_panic_page) {
pr_err("Hyper-V: panic message page memory allocation failed");
And nicer to add a terminating newline to the format like the pr_err below.
Oops, sending v3. Thanks Joe Perches!
return;
}
ret = kmsg_dump_register(&hv_kmsg_dumper);
if (ret) {
pr_err("Hyper-V: kmsg dump register error 0x%x\n", ret);
hv_free_hyperv_page((unsigned long)hv_panic_page);
hv_panic_page = NULL;
}
