On Fri, Nov 13, 2020 at 05:13:44PM +0100, Vitaly Kuznetsov wrote: > Wei Liu <wei.liu@xxxxxxxxxx> writes: > > > On Thu, Nov 12, 2020 at 04:57:46PM +0100, Vitaly Kuznetsov wrote: > >> Wei Liu <wei.liu@xxxxxxxxxx> writes: > > [...] > >> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > >> > index 67f5d35a73d3..4e590a167160 100644 > >> > --- a/arch/x86/include/asm/mshyperv.h > >> > +++ b/arch/x86/include/asm/mshyperv.h > >> > @@ -80,6 +80,10 @@ extern void __percpu **hyperv_pcpu_output_arg; > >> > > >> > extern u64 hv_current_partition_id; > >> > > >> > +int hv_call_deposit_pages(int node, u64 partition_id, u32 num_pages); > >> > +int hv_call_add_logical_proc(int node, u32 lp_index, u32 acpi_id); > >> > +int hv_call_create_vp(int node, u64 partition_id, u32 vp_index, u32 flags); > >> > >> You seem to be only doing EXPORT_SYMBOL_GPL() for > >> hv_call_deposit_pages() and hv_call_create_vp() but not for > >> hv_call_add_logical_proc() - is this intended? Also, I don't see > >> hv_call_create_vp()/hv_call_add_logical_proc() usage outside of > >> arch/x86/kernel/cpu/mshyperv.c so maybe we don't need to export them at all? > >> > > > > hv_call_deposit_pages and hv_call_create_vp will be needed by /dev/mshv, > > which can be built as a module. > > > > I'd suggest to move EXPORT_SYMBOL_GPL() to the series adding '/dev/mshv' > then. Dangling exported symbols with no users tend to be removed. No > strong opinion, just a suggestion. Sure. This is now done in my v3. Wei.
