Field names inside ms_hyperv_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all

During my work to make Linux boot as root partition on MSHV, I found out
that a privilege mask was not collected in ms_hyperv_info.

Looking at the code, the field names of ms_hyperv_info are not
consistent with the names defined in TLFS. That makes it difficult to
choose a name for the field that stores the privilege mask.

I've got a local patch to make the existing fields closer to TLFS. The
suffix "_a" means the value comes from EAX.

Given that this structure is also used on ARM, so having x86 suffix is
probably not the best idea. Do people care?

diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
index c57799684170..913af5e93cce 100644
--- a/include/asm-generic/mshyperv.h
+++ b/include/asm-generic/mshyperv.h
@@ -26,9 +26,9 @@
 #include <asm/hyperv-tlfs.h>

 struct ms_hyperv_info {
-       u32 features;
-       u32 misc_features;
-       u32 hints;
+       u32 features_a;
+       u32 features_d;
+       u32 recommendations;
        u32 nested_features;
        u32 max_vp_index;
        u32 max_lp_index;

Any comment on this? I'm normally bad at naming things so any suggestion
is welcomed.

Thanks,
Wei.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux