On Mon, Oct 05 2020 at 16:28, David Woodhouse wrote: > -static void __irq_msi_compose_msg(struct irq_cfg *cfg, struct msi_msg *msg) > +static void __irq_msi_compose_msg(struct irq_cfg *cfg, struct msi_msg *msg, int dmar) bool dmar? > +/* > + * The Intel IOMMU (ab)uses the high bits of the MSI address to contain the > + * high bits of the destination APIC ID. This can't be done in the general > + * case for MSIs as it would be targeting real memory above 4GiB not the > + * APIC. > + */ > +static void dmar_msi_compose_msg(struct irq_data *data, struct msi_msg *msg) > +{ > + __irq_msi_compose_msg(irqd_cfg(data), msg, 1); > + > + > + Lots of stray newlines...