On 18.09.20 03:53, Wei Yang wrote: > On Wed, Sep 16, 2020 at 08:34:08PM +0200, David Hildenbrand wrote: >> Let's prepare for additional flags and avoid long parameter lists of bools. >> Follow-up patches will also make use of the flags in __free_pages_ok(), >> however, I wasn't able to come up with a better name for the type - should >> be good enough for internal purposes. >> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> >> Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> >> Cc: Michal Hocko <mhocko@xxxxxxxxxx> >> Cc: Dave Hansen <dave.hansen@xxxxxxxxx> >> Cc: Vlastimil Babka <vbabka@xxxxxxx> >> Cc: Wei Yang <richard.weiyang@xxxxxxxxxxxxxxxxx> >> Cc: Oscar Salvador <osalvador@xxxxxxx> >> Cc: Mike Rapoport <rppt@xxxxxxxxxx> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> --- >> mm/page_alloc.c | 28 ++++++++++++++++++++-------- >> 1 file changed, 20 insertions(+), 8 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 6b699d273d6e..91cefb8157dd 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -77,6 +77,18 @@ >> #include "shuffle.h" >> #include "page_reporting.h" >> >> +/* Free One Page flags: for internal, non-pcp variants of free_pages(). */ >> +typedef int __bitwise fop_t; >> + >> +/* No special request */ >> +#define FOP_NONE ((__force fop_t)0) >> + >> +/* >> + * Skip free page reporting notification after buddy merging (will *not* mark > > __free_one_page() may not merge buddy when its buddy is not available. > > Would this comment be a little confusing? > I rather meant the process than if it's actually happening. "Skip free page reporting notification for the (possibly merged) page." Thanks! -- Thanks, David / dhildenb
