On Tue, Jun 16, 2020 at 12:40:32PM +0200, Peter Zijlstra wrote: > On Tue, Jun 16, 2020 at 12:33:13PM +0200, Christoph Hellwig wrote: > > sorry, s/ftrace/kprobes/. See my updated branch here: > > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/module_alloc-cleanup > > Ah the insn slot page, yes. Didn't you just loose VM_FLUSH_RESET_PERMS > there? Yes, we did. vmalloc_exec had it, but given that module_alloc didn't allocate executable on x86 it didn't. I guess we should make sure it is set by the low-level vmalloc code if exec permissions are set to sort this mess out.