> > Hi Denis, > When I added the function storvsc_suspend() several months ago, somehow I forgot > to remove the unnecessary memset(). Sorry! > > The buffer is recreated in storvsc_resume() -> storvsc_connect_to_vsp() -> > storvsc_channel_init() -> stor_device->stor_chns = kcalloc(...), so I believe > the memset() can be safely removed. I'm not sure that I understand your description. As for me, memset with 0 before memory freeing is required only for sensitive information and it's completely unrelated to memory zeroing during allocation with kzalloc/kcalloc. If it's not a sensitive information then memset could be safely removed. > Can you please make a v2 patch for it and Cc my corporate email "decui" (in To)? Yes, of course. Could I add "Suggested-by"? Thanks, Denis
