On Thu, May 07, 2020 at 03:58:31PM -0500, Rob Herring wrote: > On Wed, Apr 22, 2020 at 07:58:15PM +0000, Wei Liu wrote: > > There is a functionally identical function in pci-hyperv.c. Drop it and > > use pci_msi_get_hwirq instead. > > > > This requires exporting pci_msi_get_hwirq and declaring it in msi.h. > > > > No functional change intended. > > > > Signed-off-by: Wei Liu <wei.liu@xxxxxxxxxx> > > --- > > arch/x86/include/asm/msi.h | 4 ++++ > > arch/x86/kernel/apic/msi.c | 5 +++-- > > drivers/pci/controller/pci-hyperv.c | 8 +------- > > 3 files changed, 8 insertions(+), 9 deletions(-) > > Would be better if done in a way to remove an x86 dependency. This is a good point, Rob. I will see what I can do. Wei. > > I guess this would do it: > > #define pci_msi_get_hwirq NULL > > when GENERIC_MSI_DOMAIN_OPS is enabled.