> From: Boqun Feng <boqun.feng@xxxxxxxxx> > Sent: Wednesday, February 12, 2020 11:26 PM > > > Just a small thing: would it be slightly better if we change the name > > in the above line to HVCALL_RETARGET_INTERRUPT ? > > > > HVCALL_RETARGET_INTERRUPT is a define, so it may help to locate the > > actual value of the define here. And, HVCALL_RETARGET_INTERRUPT is > > used several times in the patchset so IMO we'd better always use > > the same name. > > This might be a good suggestion, however, throughout the TLFS header, > camel case is more commonly used for referencing hypercall. For example: > > /* HvCallSendSyntheticClusterIpi hypercall */ > > So I think it's better to let it as it is for this patch, and later on, > if we reach a consensus, we can convert the names all together. > > Thoughts? > > Regards, > Boqun Makes sense to me. Thanks for the explanation! Thanks, -- Dexuan
